Added mobile & accessible changes #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indefinities
added
design
indefinities
force-pushed
the
mobile-comfort
branch
from
e36ba18 to
4b54e32
Compare
jennydaman
reviewed
Jun 29, 2020
jennydaman
reviewed
Jun 29, 2020
jennydaman
reviewed
Jun 29, 2020
src/styles/_variables.scss
Outdated
|
|
||
| // Sizes | ||
| $hacks-page-width: 981px; | ||
| $hacks-page-width: em(981); |
There was a problem hiding this comment.
undid it because it don't work doe
There was a problem hiding this comment.
you baited me into reading https://adamwathan.me/dont-use-em-for-media-queries/
There was a problem hiding this comment.
I'm going to scream brb
jennydaman
requested changes
Jun 29, 2020
|
fixed desktop version -- it was because of container widths |
jennydaman
approved these changes
Jun 29, 2020
|
maybe you're going tor the picture book aesthetic |
|
I don't know what aesthetic I'm going for please |
- Smaller font size and final changes
indefinities
force-pushed
the
mobile-comfort
branch
from
647ab90 to
24abcf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65